Skip to content

Added sslyze parser check for successful ASN1 certificate parsing#1856

Merged
Zero3141 merged 1 commit intomainfrom
bugfix/sslyze-parser
Aug 25, 2023
Merged

Added sslyze parser check for successful ASN1 certificate parsing#1856
Zero3141 merged 1 commit intomainfrom
bugfix/sslyze-parser

Conversation

@Ilyesbdlala
Copy link
Member

@Ilyesbdlala Ilyesbdlala commented Aug 9, 2023 •
edited
Loading

Description

Resolves the following sslyze parser error found internally:

Starting Parser
Fetching result file
Fetched result file
Parser failed with error:
TypeError: Cannot read properties of null (reading 'certificate_deployments')
    at analyseCertificateDeployments (/home/app/parser-wrapper/parser/parser.js:155:81)
    at parse (/home/app/parser-wrapper/parser/parser.js:38:8)
    at main (/home/app/parser-wrapper/parser-wrapper.js:127:22)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Also added a corresponding unit-test

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Ilyesbdlala
added sslyze parser check for successful ASN1 certificate parsing
c145e2d 
Also added a corresponding unit-test

Signed-off-by: Ilyes Ben Dlala <[email protected]>
@Ilyesbdlala Ilyesbdlala added the bug Bugs label Aug 9, 2023
@Ilyesbdlala Ilyesbdlala self-assigned this Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ JAVASCRIPT eslint 2 1 1.04s
✅ JSON eslint-plugin-jsonc 1 0 2.29s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Ilyesbdlala Ilyesbdlala requested a review from Zero3141 August 25, 2023 09:05
@Zero3141 Zero3141 merged commit 3ad954b into main Aug 25, 2023
@Zero3141 Zero3141 deleted the bugfix/sslyze-parser branch August 25, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zero3141 Zero3141 Zero3141 approved these changes

Assignees

@Ilyesbdlala Ilyesbdlala

Labels

bug Bugs

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ilyesbdlala @Zero3141