Skip to content

Implemented the failIfFoundUrlsLessThan and warnIfFoundUrlsLessthan settings in ZAP Advanced#1791

Merged
Ilyesbdlala merged 2 commits intomainfrom
bugfix/failIfFoundUrlsLessThan-zap-advanced
Jul 11, 2023
Merged

Implemented the failIfFoundUrlsLessThan and warnIfFoundUrlsLessthan settings in ZAP Advanced#1791
Ilyesbdlala merged 2 commits intomainfrom
bugfix/failIfFoundUrlsLessThan-zap-advanced

Conversation

@Ilyesbdlala
Copy link
Member

Description

closes #1551

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

…Than settings in ZAP Advanced

Signed-off-by: Ilyes Ben Dlala <[email protected]>
@Ilyesbdlala Ilyesbdlala added the bug Bugs label Jul 7, 2023
@Ilyesbdlala Ilyesbdlala self-assigned this Jul 7, 2023
@Ilyesbdlala Ilyesbdlala changed the title Implemented the failIfFoundUrlsLessThan and warnIfFoundUrlsLesthan settings in ZAP Advanced Implemented the failIfFoundUrlsLessThan and warnIfFoundUrlsLessthan settings in ZAP Advanced Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ ACTION actionlint 1 5 0.31s
⚠️ JAVASCRIPT eslint 2 1 0.59s
✅ JSON eslint-plugin-jsonc 6 0 0.99s
⚠️ PYTHON black 2 1 0.79s
✅ SPELL misspell 13 0 0.05s
✅ YAML prettier 3 0 0.75s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Contributor

@Zero3141 Zero3141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace failIfFoundUrlsLessThan with warnIfFoundUrlsLessThan

@Ilyesbdlala Ilyesbdlala requested a review from Zero3141 July 11, 2023 08:07
@Ilyesbdlala Ilyesbdlala merged commit e477b0f into main Jul 11, 2023
@Ilyesbdlala Ilyesbdlala deleted the bugfix/failIfFoundUrlsLessThan-zap-advanced branch July 11, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

failIfFoundUrlsLessThan setting in ZAP Advanced seems to have no effect

2 participants