Skip to content

Removed Jest/npm/node Versions from Makefiles #1789

Merged
J12934 merged 6 commits intomainfrom
maintenance/npm-jest-version
Jul 10, 2023
Merged

Removed Jest/npm/node Versions from Makefiles #1789
J12934 merged 6 commits intomainfrom
maintenance/npm-jest-version

Conversation

@Ilyesbdlala
Copy link
Member

@Ilyesbdlala Ilyesbdlala commented Jul 4, 2023

Description

closes #1607

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

this allows running npm run test:unit or npm test:integration in the makefiles instead of npx
giving the specific jest version is no longer required. package.json is instead used

Signed-off-by: Ilyes Ben Dlala <[email protected]>
@Ilyesbdlala Ilyesbdlala self-assigned this Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 6 0 2.41s
✅ SPELL misspell 6 0 0.08s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

@J12934 J12934 merged commit 7de32f4 into main Jul 10, 2023
@J12934 J12934 deleted the maintenance/npm-jest-version branch July 10, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🔧 Maintenance: remove Jest/npm/node Versions from Makefiles

2 participants