Skip to content

IDE Statistics#697

Merged
MMory merged 11 commits into
developmentfrom
f-IDEStatistics
Feb 29, 2024
Merged

IDE Statistics#697
MMory merged 11 commits into
developmentfrom
f-IDEStatistics

Conversation

@fabianbs96
Copy link
Copy Markdown
Member

This PR adds some statistics to IDE, especially edge functions; they should be useful for debugging.

In addition, this PR restructures the AnalysisController slightly, to reduce dependencies and improve incremental builds.

@fabianbs96 fabianbs96 self-assigned this Jan 17, 2024
@fabianbs96 fabianbs96 requested a review from MMory as a code owner January 17, 2024 16:47
@fabianbs96 fabianbs96 added enhancement New feature or request refactoring labels Jan 17, 2024
Comment thread lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDELinearConstantAnalysis.cpp Outdated
Comment thread include/phasar/DataFlow/IfdsIde/EdgeFunction.h Outdated
Comment thread include/phasar/DataFlow/IfdsIde/EdgeFunctionStats.h

[[nodiscard]] size_t getNumEFsPerAllocationPolicy(
EdgeFunctionAllocationPolicy Policy) const noexcept {
assert(size_t(Policy) < NumAllocPolicies);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C-style cast?

Comment thread include/phasar/DataFlow/IfdsIde/Solver/IDESolver.h Outdated
Comment thread include/phasar/DataFlow/IfdsIde/Solver/IDESolver.h Outdated
Comment thread include/phasar/DataFlow/IfdsIde/Solver/IDESolver.h Outdated
Comment thread include/phasar/DataFlow/IfdsIde/Solver/IDESolver.h Outdated
Comment thread include/phasar/DataFlow/IfdsIde/Solver/JumpFunctions.h
Comment thread lib/Utils/EdgeFunctionStats.cpp Outdated
@fabianbs96
Copy link
Copy Markdown
Member Author

Haven't pushed the fixes yet, sry. Will push them on monday.

@fabianbs96 fabianbs96 added this to the Release 2403 milestone Feb 8, 2024
@MMory MMory self-requested a review February 29, 2024 14:58
Copy link
Copy Markdown
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@MMory MMory merged commit 1d1be21 into development Feb 29, 2024
@MMory MMory deleted the f-IDEStatistics branch February 29, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants