Skip to content

Update generate script to pass openapi spec from @seamapi/types#13

Merged
andrii-balitskyi merged 20 commits intomainfrom
update-generate-script
Apr 12, 2024
Merged

Update generate script to pass openapi spec from @seamapi/types#13
andrii-balitskyi merged 20 commits intomainfrom
update-generate-script

Conversation

@andrii-balitskyi
Copy link
Copy Markdown
Contributor

@andrii-balitskyi andrii-balitskyi commented Apr 8, 2024

Closes #11

Comment thread package.json Outdated
Comment thread scripts/generate.js Outdated
Copy link
Copy Markdown
Member

@razor-x razor-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have [.prettierrc.json](https://github.com/seamapi/python-next/blob/main/.prettierrc.json). Can you remove .prettierrc from this PR?

If we do want to change this, we should move it to it's own PR as it's confusing the diff.

Copy link
Copy Markdown
Member

@razor-x razor-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking, but please remove the duplicated prettier config before merge.

Comment thread scripts/generate.js Outdated
@andrii-balitskyi andrii-balitskyi merged commit 85db10e into main Apr 12, 2024
@andrii-balitskyi andrii-balitskyi deleted the update-generate-script branch April 12, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New code is generated when package-lock.json contains no changes

3 participants