Add preliminary polygon query#248
Merged
Merged
Conversation
LucaMarconato
requested review from
giovp and
kevinyamauchi
and removed request for
giovp
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 86.13% 84.69% -1.44%
==========================================
Files 35 35
Lines 4225 4307 +82
==========================================
+ Hits 3639 3648 +9
- Misses 586 659 +73
|
kevinyamauchi
approved these changes
May 10, 2023
Collaborator
kevinyamauchi
left a comment
kevinyamauchi
left a comment
There was a problem hiding this comment.
LGTM! Thank you @LucaMarconato
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to query SpatialData objects shapes elements.