Switch default serializer to JSON.NET - #525
Conversation
|
nice +1 from me. |
|
For the edification of those of us who weren't at NDC London, could you share the insight that lead to this PR? |
|
ah scratch that, it's already there! :) |
@filipw I'll add one to make it explicit that it should handle it... |
|
Yes, looks great! |
Switch default serializer to JSON.NET
|
excellent PR :) |
It was indeed at NDC London during the static vs dynamic cage match between Jon Skeet and Gary Bernhardt. It was me that spoke up and helped Jon work around the problem. He fired up the scriptcs REPL and did typeof(DateTime).GetMethods();and got
I told him it's just the JSV serialization for the REPL output so he quickly changed it to: typeof(DateTime).GetMethods().Select(m => m.Name); |
Switch default serializer to JSON.NET
5 participants
After the blow we got on NDC London, I think it's finally Time To Switch™. We can't really blame SS.Text when we picked it 😢
I created a new interface
IObjectSerializerand pulled the implementation into Hosting. Less dependencies in Core! 😉 There's also some new tests that demonstrated where the SS.Text serializer was failing.This fixes #288 and #377