Repository navigation
Add way to style identifiers (i.e. schema, table, and column names) #147
Description
As seen from the ‘getSegments’ tests, identifiers with backticks are classified as “string”,
it('complex query', () => {
expect(getSegments("SELECT COUNT(id), `id`, `username` FROM `users` WHERE `email` = '[email protected]' AND `foo` = 'BAR' OR 1=1"))
.toStrictEqual([
...
{ name: 'string', content: '`email`' },
...
{ name: 'string', content: "'[email protected]'" },That means that you can’t set a specific style for backticked identifiers, they just appear in the same color as strings. In the example above, `email` and '[email protected]' end up with the same styling.
Furthermore, identifiers without backticks are lumped together with whitespace and identified as “default”.:
it('test how default works', () => {
expect(getSegments('SELECT * FROM hr.emp'))
.toStrictEqual([
{ name: 'keyword', content: 'SELECT' },
{ name: 'default', content: ' ' },
{ name: 'special', content: '*' },
{ name: 'default', content: ' ' },
{ name: 'keyword', content: 'FROM' },
{ name: 'default', content: ' hr.emp' }
])
})That means that (for example) you can’t set a background-color for identifiers like “hr.emp”, because then the background-color would apply to the whitespace before “hr.emp” too, in addition to the whitespace before and after the * character.
Activity
Replace "default" token with "whitespace" and "identifier" tokens, wi…
scriptcoded commentedon Oct 4, 2023
Conversation in #148 to avoid multiple threads.
feat: Add way to style identifiers.
feat: add way to style identifiers
scriptsbot commentedon Oct 19, 2023
This issue has been marked as stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 5 days.
wkeese commentedon Oct 19, 2023
This should stay open, see #148.
feat: add way to style identifiers
chore(release): 5.0.0-beta.2 [skip ci]
github-actions commentedon Oct 24, 2023
🎉 This issue has been resolved in version 5.0.0-beta.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
feat: add way to style identifiers
chore(release): 5.0.0-beta.2 [skip ci]
feat: add way to style identifiers
feat: add way to style identifiers
chore(release): 5.0.0 [skip ci]
chore(release): 5.0.0 [skip ci]
chore(release): 6.0.0 [skip ci]
scriptsbot commentedon Jul 2, 2024
🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀