Allow picking up credentials from environment variables - #629
Merged
Merged
Conversation
keynmol
marked this pull request as ready for review
August 7, 2023 14:10
keynmol
commented
Aug 7, 2023
olafurpg
reviewed
Aug 7, 2023
| .addDependencies(deps: _*) | ||
| .addDependencies(provided: _*) | ||
|
|
||
| if (!sys.env.contains("COURSIER_REPOSITORIES")) { |
Contributor
There was a problem hiding this comment.
FYI: app.env.environmentVariables should have a copy of environment variables, which can be overridden for e2e tests of the scip-java CLI. Not something we need to think about right now, but one of the core ideas in Moped is that you inject all system dependencies via Application for cleaner testing.
olafurpg
reviewed
Aug 7, 2023
| "COURSIER_CREDENTIALS" -> s"localhost $Username:$Password" | ||
| ) | ||
|
|
||
| val tmp = os.temp.dir(prefix = "scip-java") |
Contributor
There was a problem hiding this comment.
FYI, we use FileLayout.fromString(..., root = workingDirectory) in BaseBuildToolSuite, which makes it easier to create big directory structures without multiple os.write(...) invocations.
Contributor
Author
There was a problem hiding this comment.
I'll punt this to the next PR for sure 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.noCredentialsconfiguration, which was a copypasteTest plan
Manual testing, automated seems to be quite hard to setup (but I will try, still)