Merged
Conversation
gselzer
force-pushed
the
docs/op-introspection
branch
from
e604bf9 to
6b69fa8
Compare
ctrueden
approved these changes
May 21, 2024
Member
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
This is a great first version! I made some small suggestions. The only thing I feel is missing is an explanation/discussion of RichOp—right now it is just briefly mentioned but not explained, and no API highlighted.
Member
Author
|
Thanks for looking it over @ctrueden! If you have more suggestions, I'll be happy to make them, but I think it's time to merge this guy |
gselzer
force-pushed
the
docs/op-introspection
branch
from
ba10068 to
ceb554a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185