Skip to content

fix: #990 Turn off ZipFile strict_timestamps #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scanny merged 1 commit into from
Aug 3, 2024
Merged

fix: #990 Turn off ZipFile strict_timestamps #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
Release History
---------------

0.6.24-dev0
0.6.24-dev3
+++++++++++++++++++

- fix: #943 remove mention of a Px Length subtype
- fix: #972 next-slide-id fails in rare cases
- fix: #990 do not require strict timestamps for Zip

0.6.23 (2023-11-02)
+++++++++++++++++++
Expand Down
2 changes: 1 addition & 1 deletion src/pptx/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
if TYPE_CHECKING:
from pptx.opc.package import Part

__version__ = "0.6.23"
__version__ = "0.6.24-dev3"

sys.modules["pptx.exceptions"] = exceptions
del sys
Expand Down
4 changes: 3 additions & 1 deletion src/pptx/opc/serialized.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ def write(self, pack_uri: PackURI, blob: bytes) -> None:
@lazyproperty
def _zipf(self) -> zipfile.ZipFile:
"""`ZipFile` instance open for writing."""
return zipfile.ZipFile(self._pkg_file, "w", compression=zipfile.ZIP_DEFLATED)
return zipfile.ZipFile(
self._pkg_file, "w", compression=zipfile.ZIP_DEFLATED, strict_timestamps=False
)


class _ContentTypesItem:
Expand Down
4 changes: 3 additions & 1 deletion tests/opc/test_serialized.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,9 @@ def it_provides_access_to_the_open_zip_file_to_help(self, request: FixtureReques

zipf = pkg_writer._zipf

ZipFile_.assert_called_once_with("prs.pptx", "w", compression=zipfile.ZIP_DEFLATED)
ZipFile_.assert_called_once_with(
"prs.pptx", "w", compression=zipfile.ZIP_DEFLATED, strict_timestamps=False
)
assert zipf is ZipFile_.return_value

# fixtures ---------------------------------------------
Expand Down