Repository navigation
pep8 bulk edit - #23
Merged
Merged
Conversation
Member
Author
|
@holdenk Reviewing bulk pep8 edits file by file right now. |
mlkimmins
commented
Jun 23, 2023
| setup(is_lab=True) | ||
|
|
||
| %%fsql dask | ||
| % % fsql dask |
Member
Author
There was a problem hiding this comment.
breaking change but this ex is not included as .py so ok
mlkimmins
commented
Jun 23, 2023
| # In[ ]: | ||
|
|
||
|
|
||
| bag.from_sequence(range(0,1000)).map(lambda x: (x, x)).foldby(lambda x, y: x + y, lambda x, y: x + y) |
Member
Author
There was a problem hiding this comment.
@holdenk technically pep8 is correct but pretty illegible after this edit. I'm going to undo this and just fit it within 80 char
| # In[26]: | ||
|
|
||
|
|
||
| iseven = lambda x: x % 2 == 0 |
Member
Author
There was a problem hiding this comment.
@holdenk I don't think there's a specific reason not to use 'def' construct but lmk if there is.
| #tag::ex_yarn_deployment_CLI_tuning[] | ||
| get_ipython().system('dask-yarn submit') | ||
| --environment home/mkimmins/anaconda/bin/python --worker-count 20 --worker-vcores 2 --worker-memory 4GiB your_python_script.py | ||
| --environment home / mkimmins / anaconda / bin / python - -worker - count 20 - -worker - vcores 2 - -worker - memory 4GiB your_python_script.py |
Member
Author
There was a problem hiding this comment.
autopep8 issues. this is bash and should not be done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.