Repository navigation
Refactoring TimeWindowingJava, Adding watermarked collections - #4
Merged
Merged
Conversation
Project is still in active development and expected to change Convert project from Gradle to Maven Add watermarking to Sliding and Tumbling windows Add window finalization to SlidingWindowCollection and TumblingWindowCollection
…ation to SessionWindowCollection
…dowCollection Adding missing window closed handler registration to session window collection Adding SessionWindowCollection with Watermarking test
Re-add SlidingWindowCollection, TumblingWindowCollection, and SessionWindowCollection Created seperate Watermarked-* version of each windowing collection Refactor tests to have watermarking and non-watermarking tests
Window duration was incorrectly set to the size of the window based on the duration from the window start time to the last elements timestamp and not the assigned duration by the user
Removing WindowClosedHandler, now Watermarked*WindowCollection.add returns a list of closed TimeWindows
Adding startTime to Watermarked*WindowCollection to allow for set window start and end times Adding unit test for closed empty windows
Adding WindowingCollection and WatermarkedWindowingCollection abstract classes Removing javadoc warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed build tooling from Gradle to Maven.
mvn clean installRenamed package and artifact ID:
Added abstract class WatermarkedWindowingCollection - this abstract class has three implementations:
Added WatermarkGenerator - this abstract class has an implementation:
Added WatermarkedSample in the test directory.