Skip to content

Resolve wildcard revision from BOM - #98

Merged
eed3si9n merged 1 commit into
sbt:mainfrom
gaeljw:fix-issue-97-wildcard-javaagent
Sep 21, 2026
Merged

eed3si9n merged 1 commit into
sbt:mainfrom
gaeljw:fix-issue-97-wildcard-javaagent

Conversation

@gaeljw

@gaeljw gaeljw commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Disclaimer: this was written by Claude, reviewed and guided by me.

Aims to solve #97. I'm really not sure if the fix is the best solution but it does work according to the integration test.

Content

  • Added a manually-built POM that serves as a BOM in the integration test
  • Split integration tests in SBT 1.x vs. 2.x folder + tests that should work in both (no tests that would work in 1.x only yet)
  • Added an integration tests to cover the behaviour (verified it fails without the fix)

Remaining tasks

  • Verify behaviour in a real project

@gaeljw
gaeljw force-pushed the fix-issue-97-wildcard-javaagent branch from 0e541af to 0c99e3c Compare August 18, 2026 18:42
@gaeljw
gaeljw marked this pull request as ready for review September 20, 2026 16:12
@gaeljw

gaeljw commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

I finally took the time to test on a local project and it does work.

@gaeljw

gaeljw commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor Author

cc @mkurz @eed3si9n ; I hope you don't mind me pulling you here but you're the last ones that merged / published a release :)

@eed3si9n eed3si9n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really involved in the development of this plugin, but the change itself looks good to me, and I'd be happy to push a release out.

@eed3si9n
eed3si9n merged commit d59ba42 into sbt:main Sep 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants