removed Neo environment from tutorials#5734
Closed
maxta2002 wants to merge 8 commits into
Closed
Conversation
Contributor
|
The PR shows the tutorial being completely changed, yet it looks barely changed. What did you change in the sac-embed-story tutorial? |
Contributor
Author
|
Hi Daniel,
i have removed the chapters where Neo was used.
Best regards Benedikt
From: Daniel Wroblewski <[email protected]>
Reply-To: SAPDocuments/Tutorials <[email protected]>
Date: Thursday, 27. August 2020 at 12:14
To: SAPDocuments/Tutorials <[email protected]>
Cc: "Michligk, Benedikt" <[email protected]>, Author <[email protected]>
Subject: Re: [SAPDocuments/Tutorials] removed Neo environment from tutorials (#5734)
The PR shows the tutorial being completely changed, yet it looks barely changed. What did you change in the sac-embed-story tutorial?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#5734 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGKWOOU6FAHFI2RMIEOKOO3SCYWUNANCNFSM4QJMUZ4Q>.
|
Contributor
|
I have pushed the changes myself -- your PR showed one of the tutorials being completely changed.f86998b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
as you mentioned in the mail. I have changed the turoials that we are not covering the neo environment any more.