Skip to content

WIP: Update PHP code, tests and CS#73

Merged
gonzofy merged 1 commit intosalsify:masterfrom
thePanz:update-cs-phpstan-code
Oct 26, 2018
Merged

WIP: Update PHP code, tests and CS#73
gonzofy merged 1 commit intosalsify:masterfrom
thePanz:update-cs-phpstan-code

Conversation

@thePanz
Copy link
Copy Markdown

@thePanz thePanz commented Oct 26, 2018

No description provided.

@thePanz thePanz force-pushed the update-cs-phpstan-code branch 2 times, most recently from d4c2cdb to 78a579e Compare October 26, 2018 10:06
@gonzofy
Copy link
Copy Markdown
Contributor

gonzofy commented Oct 26, 2018

@thePanz wow! Nice work. well overdue cleanup.

@thePanz thePanz force-pushed the update-cs-phpstan-code branch from 78a579e to 1c8a2d8 Compare October 26, 2018 11:10
@gonzofy gonzofy merged commit 2a8b852 into salsify:master Oct 26, 2018
@thePanz
Copy link
Copy Markdown
Author

thePanz commented Oct 26, 2018

@gonzofy this PR was still in "Work in Progress"
I'll provide another one with the final cleanups

@thePanz
Copy link
Copy Markdown
Author

thePanz commented Oct 26, 2018

Please: use a correct semantic versioning v8.0.0 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants