Scott allen - #1
Open
sallen95 wants to merge 3 commits into
Open
Conversation
DomBruno
requested changes
Sep 9, 2020
DomBruno
left a comment
DomBruno
left a comment
Collaborator
There was a problem hiding this comment.
Your implementation of Rock, Paper, Scissors doesn't adhere to the guidelines in the task (it should only take one parameter - your function requires 3 - I think using boolean 0/1 - instead of a simple string).
Let me know if you want to hop on a Zoom to work it out, or if you think you can refactor it on your own later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.