Repository navigation
Add sendEmail() support. - #13
Merged
idbentley merged 4 commits intoOct 30, 2014
Merged
Conversation
|
Thanks for the PR, everything looks grand if you could make the few changes I called up inline. |
Contributor
Author
|
@idbentley Thanks for the feedback. I agree, those docstrings were a bit excessive. I moved some of the example into the Readme and scrapped the stuff which was already in the tests. How does that look? |
Contributor
Author
|
@idbentley Any feedback or is this ok now? |
|
Looks good - will merge and cut a release soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement sendEmail() in both the xmlclient and python_client, including unit tests for both which send email to the logged-in user. Didn't bump version.