Repository navigation
Expand file tree
/
Copy pathtest_java_name_collision.py
More file actions
246 lines (211 loc) · 6.05 KB
/
Copy pathtest_java_name_collision.py
File metadata and controls
246 lines (211 loc) · 6.05 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
from pathlib import Path
from unittest.mock import MagicMock
import pytest
from codebase_rag.tests.conftest import get_relationships, run_updater
@pytest.fixture
def java_collision_project(temp_repo: Path) -> Path:
"""Create a Java project with name collisions."""
project_path = temp_repo / "java_collision_test"
project_path.mkdir()
(project_path / "src").mkdir()
(project_path / "src" / "main").mkdir()
(project_path / "src" / "main" / "java").mkdir()
(project_path / "src" / "main" / "java" / "com").mkdir()
(project_path / "src" / "main" / "java" / "com" / "example").mkdir()
(project_path / "src" / "main" / "java" / "com" / "example" / "utils").mkdir()
(project_path / "src" / "main" / "java" / "com" / "example" / "other").mkdir()
(project_path / "src" / "main" / "java" / "com" / "example" / "app").mkdir()
return project_path
def test_name_collision_prefers_explicit_import(
java_collision_project: Path,
mock_ingestor: MagicMock,
) -> None:
"""
Test that explicit imports are respected when multiple classes share a name.
"""
utils_helper = (
java_collision_project
/ "src"
/ "main"
/ "java"
/ "com"
/ "example"
/ "utils"
/ "Helper.java"
)
utils_helper.write_text(
encoding="utf-8",
data="""
package com.example.utils;
public class Helper {
public String utilsMethod() {
return "From utils package";
}
}
""",
)
other_helper = (
java_collision_project
/ "src"
/ "main"
/ "java"
/ "com"
/ "example"
/ "other"
/ "Helper.java"
)
other_helper.write_text(
encoding="utf-8",
data="""
package com.example.other;
public class Helper {
public String otherMethod() {
return "From other package";
}
}
""",
)
service = (
java_collision_project
/ "src"
/ "main"
/ "java"
/ "com"
/ "example"
/ "app"
/ "Service.java"
)
service.write_text(
encoding="utf-8",
data="""
package com.example.app;
import com.example.utils.Helper;
public class Service {
private Helper helper;
public void processData() {
helper.utilsMethod();
}
}
""",
)
run_updater(java_collision_project, mock_ingestor, skip_if_missing="java")
call_relationships = get_relationships(mock_ingestor, "CALLS")
utils_calls = 0
other_calls = 0
for call in call_relationships:
if len(call.args) > 2:
from_tuple = call.args[0]
to_tuple = call.args[2]
if isinstance(from_tuple, tuple) and len(from_tuple) >= 3:
from_qn = from_tuple[2]
if isinstance(to_tuple, tuple) and len(to_tuple) >= 3:
to_qn = to_tuple[2]
if "Service" in from_qn and "processData" in from_qn:
if "utils.Helper" in to_qn and "utilsMethod" in to_qn:
utils_calls += 1
elif "other.Helper" in to_qn:
other_calls += 1
assert utils_calls == 1, (
f"Expected 1 call to utils.Helper.utilsMethod(), found {utils_calls}. "
"The explicit import should resolve to utils.Helper."
)
assert other_calls == 0, (
f"Expected 0 calls to other.Helper, found {other_calls}. "
"Should NOT call other.Helper when utils.Helper is explicitly imported."
)
def test_name_collision_prefers_same_package(
java_collision_project: Path,
mock_ingestor: MagicMock,
) -> None:
"""
Test that when no explicit import exists, same-package classes are preferred.
"""
app_helper = (
java_collision_project
/ "src"
/ "main"
/ "java"
/ "com"
/ "example"
/ "app"
/ "Helper.java"
)
app_helper.write_text(
encoding="utf-8",
data="""
package com.example.app;
public class Helper {
public String appMethod() {
return "From app package";
}
}
""",
)
other_helper = (
java_collision_project
/ "src"
/ "main"
/ "java"
/ "com"
/ "example"
/ "other"
/ "Helper.java"
)
other_helper.write_text(
encoding="utf-8",
data="""
package com.example.other;
public class Helper {
public String otherMethod() {
return "From other package";
}
}
""",
)
service = (
java_collision_project
/ "src"
/ "main"
/ "java"
/ "com"
/ "example"
/ "app"
/ "Service.java"
)
service.write_text(
encoding="utf-8",
data="""
package com.example.app;
public class Service {
private Helper helper;
public void processData() {
helper.appMethod();
}
}
""",
)
run_updater(java_collision_project, mock_ingestor, skip_if_missing="java")
call_relationships = get_relationships(mock_ingestor, "CALLS")
app_calls = 0
other_calls = 0
for call in call_relationships:
if len(call.args) > 2:
from_tuple = call.args[0]
to_tuple = call.args[2]
if isinstance(from_tuple, tuple) and len(from_tuple) >= 3:
from_qn = from_tuple[2]
if isinstance(to_tuple, tuple) and len(to_tuple) >= 3:
to_qn = to_tuple[2]
if "Service" in from_qn and "processData" in from_qn:
if "app.Helper" in to_qn and "appMethod" in to_qn:
app_calls += 1
elif "other.Helper" in to_qn:
other_calls += 1
assert app_calls == 1, (
f"Expected 1 call to app.Helper.appMethod(), found {app_calls}. "
"Should prefer same-package Helper over distant one (import distance)."
)
assert other_calls == 0, (
f"Expected 0 calls to other.Helper, found {other_calls}. "
"Should NOT call other.Helper when app.Helper is in the same package."
)