Skip to content

feat(ops.scan_map): adds scan_map operator#274

Merged
M-Adoo merged 1 commit into
rxRust:masterfrom
molybdenumsoftware:scan_map
Apr 21, 2026
Merged

feat(ops.scan_map): adds scan_map operator#274
M-Adoo merged 1 commit into
rxRust:masterfrom
molybdenumsoftware:scan_map

Conversation

@mightyiam
Copy link
Copy Markdown
Contributor

Hey, I needed this because the Clone bound on scan was too restrictive.
And I did not need to emit the accumulated value at all.
So, this seems to do the trick.
First time contribution. Must have done something dumb. Please don't yell at me.

@mightyiam mightyiam marked this pull request as ready for review April 20, 2026 16:08
@mightyiam
Copy link
Copy Markdown
Contributor Author

I should add that I have simply copy-pasted the scan implementation and modified a few things, which seemed like a reasonable thing to do.

Copy link
Copy Markdown
Collaborator

@M-Adoo M-Adoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@M-Adoo M-Adoo enabled auto-merge April 21, 2026 04:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 93.18182% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.84%. Comparing base (b7fd604) to head (25b74a4).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ops/scan_map.rs 92.40% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   82.79%   82.84%   +0.05%     
==========================================
  Files          83       84       +1     
  Lines       11887    12196     +309     
==========================================
+ Hits         9842    10104     +262     
- Misses       2045     2092      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@M-Adoo M-Adoo added this pull request to the merge queue Apr 21, 2026
Merged via the queue into rxRust:master with commit 3f725c9 Apr 21, 2026
12 checks passed
@mightyiam mightyiam deleted the scan_map branch April 21, 2026 07:25
@mightyiam
Copy link
Copy Markdown
Contributor Author

🙏 ✨

@mightyiam mightyiam mentioned this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants