refactor(fmt): simplify SWC Next postprocessing - #528
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
7e2eee7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ab210a8.rstack-cli.pages.dev |
| Branch Preview URL: | https://soon-codex-simplify-swc-next.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The formatter adapter retains unsupported Hack pipeline handling and template-shape checks inherited from Prettier, plus repeated validation of parser-produced child nodes.
Changes
Remove those branches and repeated child-node checks while retaining parser-root validation and existing formatting normalization. Document differences from upstream with links pinned to the original port's Prettier commit.
Cover nested-template normalization, type-cast parentheses, formatting stability, and single-member unions with comments through observable output tests.
Validation: package/native builds, 42 adapter tests, lint/typecheck/formatting, and spelling passed. All 638 successful corpus cases retained identical output; additional embedded-language, range, and cursor checks also matched.