Skip to content

updated packages - #138

Merged
coykwan merged 2 commits into
rsm-hcd:mainfrom
coykwan:main
Jul 29, 2022
Merged

updated packages#138
coykwan merged 2 commits into
rsm-hcd:mainfrom
coykwan:main

Conversation

@coykwan

@coykwan coykwan commented Jul 28, 2022 •
edited by ab-gb
Loading

Copy link
Copy Markdown
Contributor
  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

@coykwan
coykwan requested review from ab-gb and rllowman July 28, 2022 21:24
ab-gb
ab-gb requested changes Jul 29, 2022
View reviewed changes

@ab-gb ab-gb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Let's adjust the react/react-dom in the package json.

Comment thread package.json Outdated
Comment thread package.json Outdated
@coykwan
coykwan requested a review from myty July 29, 2022 18:55
myty
myty approved these changes Jul 29, 2022
View reviewed changes

@myty myty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coykwan
coykwan merged commit 59d8565 into rsm-hcd:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ab-gb ab-gb ab-gb requested changes
@myty myty myty approved these changes
@rllowman rllowman Awaiting requested review from rllowman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coykwan @myty @ab-gb