Repository navigation
Conversation
Try to get Newobj only for types with constructor. Without condition an exception is thrown.
Owner
|
This will cause an exception since opcodes.stloc is still going to be called when their is no value on the stack to pop. It will be better to use an attribute to get the correct type to initialize when a constructor does not exists. Thanks, |
Author
|
Sorry, but I'm not that familiar with the framework. What do you mean by "using an attribute"? can you show an example or refer me to the relevant doc? |
Owner
|
Something like this.https://msdn.microsoft.com/en-us/library/hh194292(v=vs.110).aspx |
Author
|
I'll review. Thank you for the prompt replies! |
Owner
|
I am closing the pull request since I can merge because it will break current functionality. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to get Newobj only for types with constructor. Without condition an exception is thrown.