Skip to content

Upgrade vulnerable dependencies#238

Merged
cabarnes merged 2 commits into
rovercode:alphafrom
cabarnes:update-dependencies
Jun 16, 2019
Merged

Upgrade vulnerable dependencies#238
cabarnes merged 2 commits into
rovercode:alphafrom
cabarnes:update-dependencies

Conversation

@cabarnes
Copy link
Copy Markdown
Member

  • Had to pin prospector because the most recent version is broken
  • Newer version of autobahn which is a dependency of daphne requires cryptography which brings in a bunch of host dependencies. When we remove docker-compose.yml, we'll no longer need daphne so it didn't seem to make sense to go through that upgrade

@cabarnes cabarnes requested a review from hbradio June 16, 2019 04:08
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 16, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d5101e3 on cabarnes:update-dependencies into 520353b on rovercode:alpha.

@hbradio
Copy link
Copy Markdown
Collaborator

hbradio commented Jun 16, 2019

I think that we will continue to need Daphne. Even when we're not using docker-compose, we'll still use daphne.sh as the start command in the ECS cluster that handles websocket connections, since it will need to run the Daphne server.

@cabarnes
Copy link
Copy Markdown
Member Author

Ok, I'll look at getting the image dependencies correct for the upgrade then

Copy link
Copy Markdown
Collaborator

@hbradio hbradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@cabarnes cabarnes merged commit 2ef896a into rovercode:alpha Jun 16, 2019
@cabarnes cabarnes deleted the update-dependencies branch June 16, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants