Repository navigation
Conversation
Co-Authored-By: Quentin Rousseau <[email protected]>
Co-Authored-By: Quentin Rousseau <[email protected]>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Quentin Rousseau <[email protected]>
…lights Co-Authored-By: Quentin Rousseau <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
rootly_sdk/from the latest Rootly OpenAPI spec and makes regeneration reproducible. Past regens flip-flopped betweenUnion[Unset, str]andstr | Unset, and between with and withoutquote()on path params, because each was run with whatever openapi-python-client happened to be installed. Versions before 0.27 produce the old style. #14 was generated with one of those, after #6 and #11 had used a newer version.API changes
Reproducible regeneration
pyproject.tomladds[dependency-groups] dev = ["openapi-python-client==0.29.0; python_version >= '3.11'", "ruff==0.16.3"], locked inuv.lock. Dependabot now has auventry, so bumps to these come in as their own PRs.--meta none --output-path rootly_sdkstops the generator from overwritingpyproject.tomlandREADME.md.tools/config.yamlsetspost_hooks: []. Previously the post hooks ran whateverruffwas on PATH, sometimes before[tool.ruff]config (line-length 120) was in place.fix_openapi_escalation_paths.pyis needed because without itPUT /v1/escalation_paths/{id}(update_escalation_path) silently goes missing. It now also drops thetitleon each variant.fix_nullable_severity.pyextracts the inlinenullable_severity_response.datainto its own component. Without that, the generator emits a duplicateNullableSeverityResponseType0Dataand drops the model, which breakstests/test_incident_response.py(the Fix incident severity null deserialization #19 regression test).X | Unsetdocstrings. That is now the stable style.make generatetwice on the same spec produced byte-identical trees, and there's no diff against the committed output.Release flow, aligned with rootly-ts / rootly-swift
CHANGELOG.mdnow points to GitHub Releases. Older entries are kept under "Older releases".ChangelogURL now points to Releases.make bump-*no longer edits CHANGELOG.md.publish.ymlgains areleasejob that runs after the PyPI publish. It checks out the repo and fetches the annotated tag. It then promotes the most recent Release Drafter draft, whatever tag the draft resolved to, and renames it to the pushed tag. The annotated tag message is prepended under## Highlights. Without a draft, it falls back togh release create --verify-tag --generate-notes. This is the same logic as rootly-swift, and rootly-ts gets it in rootly-ts#43..github/PUBLISHING.mdnow recommends annotated tags.release-drafter.ymluses thebreakingandenhancementversion resolvers and thev$RESOLVED_VERSIONtag.Validation
ruff checkandruff format --checkpass (0.16.3).uv buildpasses.blacksmith-*runner label.Risk: low. This is a generated SDK refresh and doesn't touch any deployed service. Anyone using the removed endpoints will break when they upgrade, so the release should be a major bump.
Link to Devin session: https://rootly.devinenterprise.com/sessions/af696ad13f4e47a09908c76ef0b67191
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/af696ad13f4e47a09908c76ef0b67191?variant=devin
Requested by: @kwent