Repository navigation
fix(ci): let publish workflow own release publication - #76
Merged
Merged
Conversation
Co-Authored-By: Quentin Rousseau <[email protected]>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Hchanni
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release Drafter no longer runs on
v*tag pushes, and it no longer passespublish: ${{ github.ref_type == 'tag' }}(or the tag-dependentname/tag/versioninputs).Why: on
v3.0.0, two workflows raced on the same draft:release-drafter.ymlpublished the draft about 2 minutes after the tag push, whilepublish.ymlwas still deploying to Maven Central. The release went out without the tag highlights.publish.yml'sreleasejob (from Regenerate Java client from latest OpenAPI spec and publish Release Drafter drafts #74) then finds no draft. Itsgh release createfallback hits an already-existing release.After this change, only
publish.ymlpublishes the release, and only after the Maven Central and GitHub Packages deploys succeed. It promotes the newest draft, renames it to the pushed tag, and prepends the annotated tag message under Highlights.Draft name and tag now come from
.github/release-drafter.yml'sv$RESOLVED_VERSIONtemplates. This matches rootly-rs, which passes no inputs to the action.Risk: low. Workflow-only change, and actionlint shows only the existing
blacksmith-2vcpu-ubuntu-2404runner-label warning.Link to Devin session: https://rootly.devinenterprise.com/sessions/af696ad13f4e47a09908c76ef0b67191
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/af696ad13f4e47a09908c76ef0b67191?variant=devin
Requested by: @kwent