Conversation
rahulKQL
reviewed
Dec 12, 2018
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/package-info.java
Outdated
Show resolved
Hide resolved
rahulKQL
reviewed
Dec 14, 2018
google-api-client-assembly/dependencies/google-api-client-appengine-dependencies.html
Outdated
Show resolved
Hide resolved
rahulKQL
reviewed
Dec 14, 2018
google-api-client-assembly/dependencies/google-api-client-appengine-dependencies.html
Outdated
Show resolved
Hide resolved
rahulKQL
reviewed
Dec 14, 2018
google-api-client-assembly/dependencies/google-api-client-appengine-dependencies.html
Outdated
Show resolved
Hide resolved
rahulKQL
reviewed
Dec 14, 2018
| <tr class="b"> | ||
| <td>com.google.appengine</td> | ||
| <td><a class="externalLink" href="http://code.google.com/appengine/appengine-api-1.0-sdk/">appengine-api-1.0-sdk</a></td> | ||
| <td><a class="externalLink" href="https://cloud.google.com/appengine/downloads/">appengine sdk</a></td> |
There was a problem hiding this comment.
not really sure but, is this url would be better?
https://cloud.google.com/appengine/
rahulKQL
reviewed
Dec 14, 2018
| <td> | ||
| <p><b>Description: </b>The DiffUtils library for computing diffs, applying patches, generationg side-by-side view in Java.</p> | ||
| <p><b>URL: </b><a class="externalLink" href="http://code.google.com/p/java-diff-utils/">http://code.google.com/p/java-diff-utils/</a></p> | ||
| <p><b>URL: </b><a class="externalLink" href="https://code.google.com/archive/p/java-diff-utils/">java-diff-utils</a></p> |
There was a problem hiding this comment.
Would this be more appropriate https://github.com/java-diff-utils/java-diff-utils ?
rahulKQL
reviewed
Dec 14, 2018
| <ul> | ||
| <li><a | ||
| href='http://code.google.com/p/google-api-java-client/wiki/ReleaseNotes#Version_${project.version}'>Release | ||
| href='https://github.com/googleapis/google-api-java-client#Version_${project.version}'>Release |
There was a problem hiding this comment.
I think this should be something like https://github.com/googleapis/google-api-java-client/releases/tags/${project.version}
rahulKQL
reviewed
Dec 14, 2018
| <h3>Maven Usage</h3> | ||
| For information on how to add these libraries to your Maven project please see | ||
| <a href='http://code.google.com/p/google-api-java-client/wiki/Setup#Maven'>http://code.google.com/p/google-api-java-client/wiki/Setup#Maven</a>. | ||
| <a href='https://github.com/googleapis/google-api-java-client#Maven'>Maven</a>. |
There was a problem hiding this comment.
instead of 'https://github.com/googleapis/google-api-java-client#Maven', update it with 'https://github.com/googleapis/google-api-java-client#building-locally'
There was a problem hiding this comment.
ohh sorry, I think https://developers.google.com/api-client-library/java/google-api-java-client/setup#maven be bettter
rahulKQL
reviewed
Dec 14, 2018
| <p> | ||
| Please read <a | ||
| href="http://code.google.com/p/google-http-java-client/wiki/Setup#ProGuard">Setup | ||
| href="https://github.com/googleapis/google-http-java-client#ProGuard">Setup |
There was a problem hiding this comment.
rahulKQL
reviewed
Dec 14, 2018
| <br /> Please see the | ||
| <a href='http://code.google.com/p/google-api-java-client/wiki/Android'>Android | ||
| wiki</a> for the Android Developer's Guide. | ||
| <a href='https://github.com/googleapis/google-api-java-client'>Android |
There was a problem hiding this comment.
rahulKQL
reviewed
Dec 14, 2018
google-api-client-xml/src/main/java/com/google/api/client/googleapis/xml/atom/package-info.java
Outdated
Show resolved
Hide resolved
rahulKQL
reviewed
Dec 14, 2018
| * Google-specific implementation of the OAuth 2.0 request for an access token based on an | ||
| * authorization code (as specified in <a | ||
| * href="http://code.google.com/apis/accounts/docs/OAuth2WebServer.html">Using OAuth 2.0 for Web | ||
| * href="https://developers.google.com/identity/protocols/OAuth2WebServer?csw=1">Using OAuth 2.0 for Web |
rahulKQL
reviewed
Dec 14, 2018
| * Redirect URI to use for an installed application as specified in <a | ||
| * href="http://code.google.com/apis/accounts/docs/OAuth2InstalledApp.html">Using OAuth 2.0 for | ||
| * Installed Applications</a>. | ||
| * href="https://developers.google.com/identity/protocols/OAuth2InstalledApp?csw=1">Using OAuth 2.0 for |
rahulKQL
reviewed
Dec 14, 2018
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/package-info.java
Outdated
Show resolved
Hide resolved
rahulKQL
reviewed
Dec 14, 2018
| * <p> | ||
| * These are the typical steps of the web server flow based on an authorization code, as specified | ||
| * in <a href="http://code.google.com/apis/accounts/docs/OAuth2WebServer.html">Using OAuth 2.0 for | ||
| * in <a href="https://developers.google.com/identity/protocols/OAuth2WebServer?csw=1">Using OAuth 2.0 for |
rahulKQL
reviewed
Dec 14, 2018
| * <p> | ||
| * These are the typical steps of the the browser-based client flow specified in <a | ||
| * href="http://code.google.com/apis/accounts/docs/OAuth2UserAgent.html">Using OAuth 2.0 for | ||
| * href="https://developers.google.com/identity/protocols/OAuth2UserAgent?csw=1">Using OAuth 2.0 for |
rahulKQL
reviewed
Dec 14, 2018
| /** | ||
| * Data class representing the Google JSON error response content, as documented for example in <a | ||
| * href="https://code.google.com/apis/urlshortener/v1/getting_started.html#errors">Error | ||
| * href="https://developers.google.com/url-shortener/v1/getting_started?csw=1#errors">Error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #googleapis#1187