passing client_options to S3 object store #1

Activity

1. roeap commented on Feb 1, 2023

   

   roeap

   on Feb 1, 2023

   Owner

   More actions

   Hey @cabrrtt, some of the storage otions end up as client options, but most are currently not passed down.

   That said, it would be quite easy to add that. Would you expect to pass this as part of the current storage options, or in a separate map? ALso would you care about configuring retry options, which are internally handled separately?
2. cabrrtt commented on Feb 1, 2023

   

   cabrrtt

   on Feb 1, 2023

   Author

   More actions

   Good questions! It's probably a question of what is the most pythonic approach. In my case I wish to pass a map of arbitrary headers down to ClientOptions, and for that a dict is the most natural route I believe.

   Regarding retry, I think this is also necessary. Does it make sense to follow the same signature as the Rust api, as a nested dict?

   retry_config = {
     "max_retries": int,
     "retry_timeout": int ms,
     "backoff": {
       "init_backoff": int ms,
       "max_backoff": int ms,
       "base": float
     }
   }
   
3. cabrrtt commented on Feb 1, 2023

   

   cabrrtt

   on Feb 1, 2023

   Last edited by cabrrtt

   Author

   More actions

   I think logically this would mean if it were to follow the Rust api, for headers:

   default_headers: {
      "x-amz-meta-...": string,
      ...
   }
   

   though ergonomically this feels better named just headers(?)