Conversation
pekkaklarck
requested changes
Sep 24, 2026
pekkaklarck
left a comment
pekkaklarck
left a comment
Member
There was a problem hiding this comment.
Please clarify or remove comments.
| below, an argument name in the one above. Seven rem is about thirteen | ||
| monospace characters, which covers nine in ten of the argument names in | ||
| the standard libraries. It is a minimum and not an alignment: a longer | ||
| name still widens the column. */ |
Member
There was a problem hiding this comment.
This is a rather confusing comment in general and especially the first sentence looks gibberish to me. Isn't the point that these columns have a minimum width? In that case, why is a comment needed in the first place when the style that's commented contains min-widht: 7rem?
This mush be an AI generated doc. There's nothing wrong in using AI, but the results should be reviewed and modified when needed.
| {{! A column that would have nothing in it is left out | ||
| altogether, as in the argument table above. A | ||
| keyword can document what it returns without | ||
| annotating a type. }} |
Member
There was a problem hiding this comment.
This looks like a very verbose way to say "Hide empty columns". I'm not sure is a comment really needed here in the first place.
Give the argument name column a minimum width
aaltat
force-pushed
the
libdoc_table_columns
branch
from
September 24, 2026 17:47
96e703c to
63b8c31
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the argument name column a minimum width