Conversation
Signed-off-by: Mingyang Wu <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
data.timeoutin astart_testlistener currently leaves the original timeout active, so listeners cannot add, extend, or disable test timeouts. Refresh the active timeout when a listener changes the setting, remove the original timer, and measure the updated timeout from the original test start.The change keeps the existing
TestTimeoutresult type and resolves variables after listeners run. Regression tests cover adding, shortening, extending, removing, disabling, invalid values, variables, setup execution, and unchanged settings. Keyword timeout changes already work; the new tests cover that behavior too. A deterministic unit test verifies that listener execution time counts toward the updated timeout.Validation on macOS with Python 3.13.5:
invoke formaton the changed Python files andgit diff --checkpassed.Fixes #5350.
Prepared with OpenAI Codex assistance, including implementation, tests, and an independent Codex review.