Skip to content

Prepare for 1.7.2 release#457

Merged
just-be-dev merged 3 commits intomasterfrom
1.7.2-release
Jul 22, 2015
Merged

Prepare for 1.7.2 release#457
just-be-dev merged 3 commits intomasterfrom
1.7.2-release

Conversation

@just-be-dev
Copy link
Contributor

No description provided.

@just-be-dev
Copy link
Contributor Author

@emanlove, there's an issue with #450 that's causing the test to fail. I've corrected one issue that I found (which I missed in the review). I've got to go to lunch, but I'll take a fresh look at this when I get back.

After this is cleared up I'm ready to release.

@just-be-dev
Copy link
Contributor Author

Hopefully this will shore up any errors that there were and we can push out the release 🙏

@just-be-dev
Copy link
Contributor Author

Looks like we're good! I'm going ahead with the release.

@just-be-dev
Copy link
Contributor Author

... or not.

@emanlove, There are five tests failing from my machine from the Acceptance.Multiple Browsers testsuite.

I'm getting

WindowsError: [Error 145] The directory is not empty: 'c:\\users\\USER\\appdaa\\local\\temp\\tmpzvunnb.webdriver.xpi\\components'

I think this is likely because of my anti-virus though... will you run the suites and make sure everything is okay on your machine?

EDIT: I can't reproduce this on any other environment. I hate my computer.

just-be-dev added a commit that referenced this pull request Jul 22, 2015
@just-be-dev just-be-dev merged commit 53b6c7a into master Jul 22, 2015
@just-be-dev just-be-dev deleted the 1.7.2-release branch July 24, 2015 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant