We seriously didn't already have this? 0.o

Wow. Heh. Anyway, @ekasteel, it looks good to me. Can you add a test and update the changelog? Thanks!

Could you merge in master? There was an error that was causing tests to fail, but it should be fixed now.

not sure what went wrong. things look messy, I do not want the commits for the test to be part of the pull request ( at least not until I am sure they work fine )

It's not your changes that are failing, it's an issue with the newest version of selenium. Another PR already fixed the issue, so updating your PR should correct the tests.

the keyword now has a test which passes. looks fine to me
please note the example is from boakley and fixes issue #292 "Add ability to type into a prompt"

Looks good! Would you mind updating the change log? After that I'll merge it in.

change log updated

Thanks.

Could you take a look at this?

https://travis-ci.org/rtomac/robotframework-selenium2library/jobs/72146078

I'm going to revert your changes for now, they're holding up a hotfix that we have to get out.

Edit: Unless I can figure them out pretty quickly. I'm going take another look at this after lunch.

This error is not occurring on my machine (Linux / Firefox 23). Not saying that we are good to go just that I am not seeing the error. This doesn't surprise me as I have seen other system differences.

I will note that the test for this isn't actually verifying anything. It should check to see that the name shows up on the page (as the test page is currently coded). Also this should probably be a part of the acceptance.keywords.javascript test suite and not necessarily it's own.

I'll make those changes. I think I fixed the error that Travis was running into.