Update#1
Merged
Merged
Conversation
This will aid accessibility. Closes #16129
… component is dirty checked. (#16592) Previously a projected view was only dirty checked when the component in which it was inserted was dirty checked. This fix changes the behavior so that a view is also dirty checked if the declaring component is dirty checked. Note: This does not change the order of change detection, only the fact whether a projected view is dirty checked or not. Fixes #14321
This code only runs in ES5 mode in the test suite, so this is difficult to test. However `updateFromTemplate` is being called with a spread operator, as `...updateFromTemplate(...)`. The spread operator should fail on `null` values. This change avoids the problem by always returning a (possibly empty) array. PR Close #16547
closes #16608 Formerly, tried to navigate when user clicked an anchor with an image url (to view image in a new tab) resulting in 404. Now ignores href URL with any extension and lets browser handle it.
closes #16482 Usability feature. When long embedded TOC, collapsing it should scroll user to TOC top, not leave in the middle of the page.
Working through obvious non-image content defects, from top of menu (Getting Started) through Fundamentals/Components.
This information is not relevant to users, right now. Closes #16641
* docs(animations): fix links to `Component` animations * docs(core): fix links to `ReflectiveInjector` methods The `resolve` and other methods were moved from the `Injector` to the `ReflectiveInjector`. * docs(core): fix links to `Renderer` The local links were assuming that that methods were on the current document (e.g. `RootRenderer`), but they are actually on the `Renderer` class. * docs(router): fix links to methods * docs(forms): fix links to methods * docs(core): fix links to methods * docs(router): fix API page links and an internal link
* fix(aio): allow code blocks to clear floated images Previously the negative margin on the code headings were causing floated images to overlay the start of a code block. Now all code block successfully clear all floated elements. * feat(aio): add a `.clear` class for clearing floating images * fix(aio): tidy up image styles The css rules for `img.right` and `img.left` allow authors easy access to floating an image on the left or right, respectively. The `.image-display` rule which was always found on a figure has been simplified so that all figures have this styling. It is very unlikely that a figure will be used outside the content area; and at this time it seems like `figure` is as good an indicator that we want this kind of styling as anything. Now that images are all tagged with width and height values, we cannot assume to modify these dimensions via CSS as it can cause the image to lose its correct proportions. Until we find a better solition we must set `height` to `auto` when the screen width is below 1300px to ensure that these images maintain their proportions as they get shrunk to fit. * docs(aio): general tidy up of image HTML in guides Previously, the guides have a lot of inline image styling and unnecessary use of the `image-display` css class. Images over 700px are problematic for guide docs, so those have been given specific widths and associated heights. * docs(aio): use correct anchor for "back to the top" link The `#toc` anchor does not work when the page is wide enough that the TOC is floating to the side. * build(aio): add `#top-of-page` to path variants for link checking Since the `#top-of-page` is outside the rendered docs the `checkAnchorLinks` processor doesn't find them as valid targets for links. Adding them as a `pathVariant` solves this problem but will still catch links to docs that do not actually exist. * fix(aio): ensure that headings clear floated images * fix(aio): do not force live-example embedded image to 100% size This made them look too big, generally. Leaving them with no size means that they will look reasonable in large viewports and switch to 100% width in narrow viewports.
…16562) The expression type checker moved from the language service to the compiler-cli in preparation to using it to check template expressions.
Without any major refactoring these changes bring the TOC much closer to how the Google developer docs TOC looks. Closes #16646
Due to the new structure of `live-example`, the only style in `_live-example.scss` was not applied. This is OK according to #15935 (comment), since we want it to take the full width. Fixes #15935
cli's scripts setup evals strings which requires too much escaping that bloats the code
This improves code readability and maintainability.
this file needs to remain in the repo for us to remain verified as owners of aio-staging.firebaseapp.com.
Use this file if we need to turn off the service worker in deployed sites in an emergency where the worker has a bug that is blocking the application from working. Closes #16897
- Add styling for active TOC item - Add sidenav styles - Change header tags to divs from index marketing page to remove anchors - Fix use of card mixin and create separate card-docs class - Add marketing styling - Topnav styling when on home landing page - Remove hamburger menu on home page - Add fully rounded border to top nav toolbar search input - Add mobile styles - Add title banner to other marketing pages
I chose to use unknown=polyfill option as per recommendation found at polyfillpolyfill/polyfill-service#852 (comment)
…ssion prefixing (#17063)
…#16990) Locales with no rules were using the wrong plural rule instead of the default.
Now converts shorthand imports for every TypeScript target. Tsickle is able to expand index shorthand imports for every TypeScript target and module possibility. Expanding shorthand imports for CommonJS modules is also helpful when testing in the browser. Module loaders like SystemJS are not able to understand directory imports (or index shorthand imports)
There seems to have been a bad rebase of #16228 on top of #16959, which affected ToC styles from both PRs. This commit restores the horizontal line under `.h1` elements and the vertical blue bar on the left-hand side of the ToC (with the circle running along the bar to indicate the active section). Fixes #17098
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: