Repository navigation
nle: Add version 1.3.0 - #3374
Merged
Merged
Conversation
NetHack Learning Environment: pybind11/CMake extension over the NetHack game engine (NGPL-licensed), no riscv64 wheel on PyPI (manylinux x86_64/ aarch64 only, cp310-cp313). Mirrors upstream's own cibuildwheel job from .github/workflows/test_and_deploy.yml, narrowed to riscv64 (dnf instead of yum for the manylinux2014-vs-Rocky-10 package manager difference). Patches the FetchContent-fetched septag/deboost.context dependency (pinned by nle's own CMakeLists.txt) to add the riscv64 branch its own CMake arch dispatch is missing: it already ships riscv64 fcontext assembly (asm/*_riscv64_sysv_elf_gas.S) but never selects it, silently falling through to the x86_64 files instead.
luhenry
marked this pull request as draft
October 16, 2026 00:04
The inline `sed` PATCH_COMMAND added for deboost.context never ran: with
nle's cmake_minimum_required(3.28) FetchContent populates through a
generated sub-build project, and re-serializing the command into it
expanded ${CMAKE_SYSTEM_PROCESSOR}, stripped the quotes and the `\/`
escapes, so every build failed at configure time with
"sed: -e expression #1, char 19: unknown option to `s'".
Do the edit from a small `cmake -P` script added by the patch instead;
only its path has to survive the sub-build round trip. The script is
idempotent and a no-op if deboost.context gains its own riscv64 branch.
Also set SETUPTOOLS_SCM_PRETEND_VERSION: applying the patch leaves the
tagged checkout dirty, so setuptools_scm would otherwise version the
wheel 1.3.1.dev0+g<sha>.d<date> (the failing runs already reported
"Building nle backend version: 1.3.1").
And fix the test step the build never reached: numpy and psutil only
resolve to riscv64 wheels from pypi.riseproject.dev, and
test_profile.py needs the pytest-benchmark fixture even though it skips
its benchmarks when CI=true (upstream tests against nle[all]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nle1.3.0The NetHack Learning Environment: a pybind11/CMake C++ extension over the
NetHack game engine. Upstream publishes no riscv64 wheel (manylinux x86_64/
aarch64 only, cp310-cp313).
Mirrors upstream's own
test_and_deploy.ymlbuild_wheelsjob (cibuildwheel,config in
pyproject.toml's[tool.cibuildwheel]).Differs from upstream
CIBW_BEFORE_ALLusesdnfinstead ofyum- our manylinux image is Rocky10-based, upstream's
manylinux2014is CentOS 7-based.PATCH_COMMANDto thedeboost_contextFetchContent_DeclareinCMakeLists.txt(see Patches) - the vendored dependency already shipsriscv64 fcontext assembly but its own CMake arch dispatch never selects it.
Matrix: cp310-cp313 only - upstream's own
[tool.cibuildwheel]build liststops at cp313; no cp314/cp314t wheels on any platform either.
Testing
test_manylinux_3_13job (pytestovernle/tests,staged via
CIBW_TEST_SOURCESto avoid thenle/import-shadowing the testdirectory sits under)
License: OK
Patches
0001-cmakelists-riscv64-fcontext-dispatch.patch- To upstream. Without it,septag/deboost.context(fetched viaFetchContent, pinned by thisproject) silently builds its x86_64 fcontext assembly on riscv64 instead of
the riscv64 files it already ships but never dispatches to.
Not built locally: no CMake/C++ toolchain in this sandbox.