Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: reva2/jsonapi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.x.x-dev
Choose a base ref
...
head repository: reva2/jsonapi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 123 files changed
  • 3 contributors

Commits on Sep 18, 2024

  1. Replace 'doctrine/annotations' with native PHP attributes

    Sergey Revenko
    Sergey Revenko committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    19fce42 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #15 from reva2/feature/attributes 

    Replace 'doctrine/annotations' with native PHP attributes
    @reva2
    reva2 authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    12c2e09 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Update PHP version requirements

    Sergey Revenko
    Sergey Revenko committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    09a7cad View commit details
    Browse the repository at this point in the history

  2. Merge pull request #16 from reva2/bugfix/php-version-issue 

    Update PHP version requirements
    @reva2
    reva2 authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    efa4ca0 View commit details
    Browse the repository at this point in the history

  3. Fix issue with 'symfony/http-kernel' version requirements

    Sergey Revenko
    Sergey Revenko committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3b2edfe View commit details
    Browse the repository at this point in the history

  4. Merge pull request #17 from reva2/bugfix/dependencies-issue 

    Fix issue with 'symfony/http-kernel' version requirements
    @reva2
    reva2 authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d2b4674 View commit details
    Browse the repository at this point in the history

  5. Fix issue with missing dependency for 'doctrine/cache'

    Sergey Revenko
    Sergey Revenko committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a42294a View commit details
    Browse the repository at this point in the history

  6. Merge pull request #18 from reva2/bugfix/doctrine-cache-issue 

    Fix issue with missing dependency for 'doctrine/cache'
    @reva2
    reva2 authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a7a41ae View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Replace 'doctrine/cache' with 'symfony/cache'

    Sergey Revenko
    Sergey Revenko committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    521c838 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #19 from reva2/feature/psr-cache 

    Replace 'doctrine/cache' with 'symfony/cache'
    @reva2
    reva2 authored Sep 22, 2024
    Configuration menu
    Copy the full SHA
    ee82dba View commit details
    Browse the repository at this point in the history

  3. Fix issue with invalid characters in cache keys

    Sergey Revenko
    Sergey Revenko committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    6f02ff8 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #20 from reva2/bugfix/cache-keys-issue 

    Fix issue with invalid characters in cache keys
    @reva2
    reva2 authored Sep 22, 2024
    Configuration menu
    Copy the full SHA
    a079ce3 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2024

  1. Upgrade to neomerx/json-api:4.x (#21) 

    * Upgrade to neomerx/json-api:4.x
    @reva2
    reva2 authored Dec 10, 2024
    Configuration menu
    Copy the full SHA
    02cea2a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2024

  1. Fix various small issues (#22) 

    * Fix various small issues
    @reva2
    reva2 authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    1caeaa6 View commit details
    Browse the repository at this point in the history

  2. Set default value for sortParameters to null 

    Previously, the sortParameters property was uninitialized, which could lead to unexpected behavior. This change ensures it has a default null value, improving consistency and preventing potential issues.
    Sergey Revenko
    Sergey Revenko committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    0641fc6 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #23 from reva2/bugfix/list-query-params-issue 

    Set default value for sortParameters to null
    @reva2
    reva2 authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    c26a5ee View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2026

  1. Fix missing #[Assert\Callback] on query parameters validation 

    During the migration to PHP 8 attributes the validateIncludePaths() and
validateFieldSets() callbacks in QueryParameters kept only the legacy
@Assert\Callback() docblock annotation. Under symfony/validator 7 annotations
are no longer read, so these callbacks were silently ignored and allowed
include paths / field sets were never validated. Add the #[Assert\Callback()]
attribute matching the already-migrated ListQueryParameters.

Also complete the same annotation->attribute migration missed on the Office
test fixture (@API\Id / @API\Attribute) and drop leftover doc annotations that
already had their attribute equivalents in place.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
    Sergey Revenko @claude
    Sergey Revenko and claude committed Jul 24, 2026
    Configuration menu
    Copy the full SHA
    ae20650 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #25 from reva2/bugfix/query-params-validation-issue 

    Fix missing #[Assert\Callback] on query parameters validation
    @reva2
    reva2 authored Jul 24, 2026
    Configuration menu
    Copy the full SHA
    4ed95ff View commit details
    Browse the repository at this point in the history
Loading