Repository navigation
Conversation
Contributor
|
Hi, thanks for doing this, could you give me some context about this PR? |
Contributor
There was a problem hiding this comment.
I believe next could be called multiple times if you move it in here.
i === length will be subject to a race condition depending on the speed of the filesystem. If files is an array of 10, and you read all 10 files, you will be checking a length of 10, to 1 - 10, but conceivably you could read the first file, before the next forEach loop is run, which would be length === 1 and i === 1.
If you are looking for a way to ensure that you call next after all files have been read, then the check should be more resilient to race conditions.
Contributor
|
no longer an issue since it's fixed as part of #847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.