Make the project—not the module—the compiler’s lifetime boundary - #8675
Closed
fhammerschmidt wants to merge 3 commits into
Closed
fhammerschmidt wants to merge 3 commits into
fhammerschmidt wants to merge 3 commits into
Conversation
Signed-off-by: Florian Hammerschmidt <[email protected]>
Signed-off-by: Florian Hammerschmidt <[email protected]>
fhammerschmidt
added this pull request to stack #8668
September 25, 2026 18:53
Signed-off-by: Florian Hammerschmidt <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## faster-rewatch-ocaml-signature-cache #8675 +/- ##
========================================================================
+ Coverage 78.27% 78.40% +0.13%
========================================================================
Files 481 481
Lines 65663 65729 +66
========================================================================
+ Hits 51396 51537 +141
+ Misses 14267 14192 -75
🚀 New features to boost your workflow:
|
This was referenced Sep 25, 2026
Member
Author
|
Superseded by consolidated PR #8680, which preserves this work as one commit in the combined review branch. |
fhammerschmidt
removed this pull request from stack #8668
September 26, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measurements
On a synthetic 1,201-module project, the project cache did not show a separate clean-build wall-time gain over the runtime-only cache: nine interleaved pairs measured 839.4 ms versus 843.4 ms. A seven-edit retained-watch gate measured 77 ms in each mode. Moving text capture to memory reduced summed parse-request setup time from 1,211 ms to 11 ms across 1,202 requests; typed CMI checks reduced summed verification time from about 170 ms to 8 ms across 1,201 implementation jobs. See the benchmark README for scope and method.
The available testrepo dependencies came from a Linux container, so the larger testrepo gate was not run on macOS. Its cross-edit performance on larger projects remains unmeasured.
Stack
Depends on #8673.
Validation
make checkformatmake testmake test-rewatchsh rewatch-ocaml/tests/run.sh _build/default/rewatch-ocaml/rescript_ocaml.exe(passed with filesystem event access)