Skip to content

Terminate service correctly with the maxfail option#152

Merged
DzmitryHumianiuk merged 1 commit into
reportportal:masterfrom
iivanou:handle_exitfirst_correctly
Jan 3, 2020
Merged

Terminate service correctly with the maxfail option#152
DzmitryHumianiuk merged 1 commit into
reportportal:masterfrom
iivanou:handle_exitfirst_correctly

Conversation

@iivanou

@iivanou iivanou commented Dec 10, 2019

Copy link
Copy Markdown
Collaborator

Fixes #151 .

Comment thread tests/test_plugin.py Outdated
mocked_session.config._reportportal_configured = True
mocked_session.config.py_test_service.terminate_service = Mock()
pytest_sessionfinish(mocked_session)
mocked_session.config.py_test_service.\

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using extra var to avoid line cutters

@scanters scanters left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iivanou iivanou force-pushed the handle_exitfirst_correctly branch from 1f607af to 32544c6 Compare December 18, 2019 11:07
@iivanou iivanou force-pushed the handle_exitfirst_correctly branch from 32544c6 to fdd7c87 Compare December 18, 2019 11:23
@DzmitryHumianiuk DzmitryHumianiuk merged commit bb9fc8a into reportportal:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReportPortal Stucks Forever with Pytest -x or Pytest maxfail=1

3 participants