template-fonts - #171
Merged
Merged
template-fonts#171
Conversation
ArtyomHov
reviewed
Apr 10, 2019
ArtyomHov
reviewed
Apr 10, 2019
| - [Check if project is Lego](#check-if-project-is-lego) | ||
| - [Get project title](#get-project-title) | ||
| - [Get mute music](#get-mute-music) | ||
| - [Get mute music](#get-mute-music) |
Contributor
There was a problem hiding this comment.
Duplicated line.
ArtyomHov
reviewed
Apr 10, 2019
ArtyomHov
reviewed
Apr 10, 2019
ArtyomHov
reviewed
Apr 10, 2019
| `getTemplateVailabeFonts` function returns object containing all fonts. | ||
| The object which returned has method `getFontById` which accepts `fontId` as parameter. | ||
| `getFontId` method return flatten font. | ||
|
|
Contributor
There was a problem hiding this comment.
Please write this way:
getTemplateAvailabeFonts function returns an object containing all fonts. The returned object has getFontById method which accepts fontId parameter.
getFontId method returns flattened font.
Contributor
There was a problem hiding this comment.
it is not understandable it returns an id of a single font or all ids of available fonts.
ArtyomHov
reviewed
Apr 10, 2019
ArtyomHov
reviewed
Apr 10, 2019
ArtyomHov
approved these changes
Apr 10, 2019
This was referenced Apr 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.