Feat: added ordinal day format for dates#732
Open
AbdelRahmanRahal wants to merge 2 commits into
Open
Conversation
Author
|
Fixed the failing test case to include the new feature. Feel free to add a dedicated test case for it, or let me know and I'll add one. That being said, the failing ty check is not on my part. A search tells me ty was updated and no longer needs those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in my CV's I would copy paste this line:
I am tired of doing that :p
I added DAY_ORDINAL to the date templates to support this.
It allows for something like this
Which would show: 6th July, 2025.
It automatically adjusts for "1st", "2nd", and "3rd" correctly.
It's kind of hacky, but I did not want to import any extra dependencies for such a trivial feature. If there's a better way to natively achieve this that I do not know about, please let me know.