Fix: Prevent local file access via YAML path fields (path containment) - Closed due to inefficient fix#597
Closed
alpernae wants to merge 1 commit into
Closed
Conversation
Author
|
Closed due to inefficient fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a local file access vulnerability where YAML path fields (e.g.,
cv.photo) could reference arbitrary absolute paths outside the input directory, leading to potential disclosure of sensitive files during rendering.Key changes:
resolve_relative_pathnow enforces that all resolved paths must be contained within the input YAML's directory. Absolute or escaping paths are rejected.test_yaml_path_containment.py) to verify that paths outside the input directory are not allowed, and that valid relative paths within the directory are accepted.Impact: