feat: add --dont-generate-pdf/-nopdf CLI option#491
Closed
franklintra wants to merge 1 commit into
Closed
Conversation
Add new command-line switch to disable PDF generation while still generating the intermediate Typst file. This allows users to use the .typ output as an intermediate file for their own processing workflows. When PDF generation is disabled, PNG generation is also automatically skipped since PNGs are rendered from the PDF. Fixes rendercv#481
Contributor
|
The description of this PR is better, but #482 is more complete (e.g. it updates the JSON schema, this one does not). Edit: The other PR got merged, this can be closed. Thank you for your contribution either way! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dont-generate-pdf(short form:-nopdf) to disable PDF generationMotivation
As requested in #481, this feature allows users to skip PDF generation when they only need the intermediate
.typfile, similar to the existing-nopngoption.Changes
dont_generate_pdffield toRenderCommandSettingsdata model--dont-generate-pdf/-nopdfto the render commandrun_rendercv_with_printerfunction to conditionally skip PDF generationTest Plan
--dont-generate-pdfflag - only generates .typ, .md, and .html files-nopdfshort form - works correctlydict.get())Fixes #481