Add IMDB social network#479
Merged
Merged
Conversation
Member
|
Thank you. |
IanHollow
pushed a commit
to IanHollow/rendercv
that referenced
this pull request
Oct 22, 2025
* Add IMDB social network to CV model * Add IMDB to schema.json with other social networks * Add tests for IMDB social Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds an IMDB social network for those with an IMDB name page (not to be confused with an IMDB account, eg for rating films). More information here: https://help.imdb.com/article/imdb/general-information/what-s-the-difference-between-an-imdb-page-and-user-profile/GHQEDYZ5DJ5Y8G5S#
This is is my first major PR for this project so feedback welcome. I tried to follow the guide here: https://docs.rendercv.com/developer_guide/faq/.
Thanks!