Skip to content

Arbitrary keys bug?#457

Merged
sinaatalay merged 2 commits into
rendercv:mainfrom
corwinmacmillan:arbitrary-keys
Oct 22, 2025
Merged

Arbitrary keys bug?#457
sinaatalay merged 2 commits into
rendercv:mainfrom
corwinmacmillan:arbitrary-keys

Conversation

@corwinmacmillan
Copy link
Copy Markdown
Contributor

It seems that this line in templater.py originally would always return None. Since arbitrary keys in the yaml was not working properly, I assume it is meant to return the artbitrary keys. If so, I fixed it, so that it would return arbitrary keys.

panlab added 2 commits July 20, 2025 18:29
…ys that contain other keywords (e.g. CONFERENCE_DATE) from getting erroneously replaced.
@corwinmacmillan corwinmacmillan deleted the arbitrary-keys branch August 21, 2025 00:46
@corwinmacmillan corwinmacmillan restored the arbitrary-keys branch August 21, 2025 00:48
@sinaatalay
Copy link
Copy Markdown
Member

Sorry for very late response. Did you test if this fixes the issue? If so, I'll merge.

@corwinmacmillan
Copy link
Copy Markdown
Contributor Author

Yes, it works in the examples I tested (e.g. arbitrary_key then doing ARBITRARY_KEY in the template section). I can add arbitrary keys to the examples, but I thought this might be cleaner

@sinaatalay sinaatalay merged commit 24f2218 into rendercv:main Oct 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants