Link docker and pypi releases#321
Merged
Merged
Conversation
Member
|
Thank you! |
Contributor
Author
|
@sinaatalay the release is failing. |
Member
|
Ahh, right. Thank you, I was trying to figure out why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #320
This resolves the race condition between the pypi and docker workflows when triggered by a github release by combining the two workflows and having docker depend on pypi.
I added the "release" environment to the docker job in order to match what was in the pypi job, though I don't think you actually use deployments and/or environments.
While the changes are straightforward, I don't know of a way to test for issues until the next release.