Twitter social#212
Conversation
|
Thank you. Twitter and its icon don't exist anymore. Therefore, I think including it would be wrong. I think we need to go for the X icon somehow. |
| 3. Set `update_testdata` to `True` in `conftest.py` and [run the tests](./testing.md) to update the `testdata` folder. | ||
| 4. Review the updated `testdata` folder manually to ensure everything works as expected. Then, set `update_testdata` to `False` and push the changes. | ||
|
|
||
| Finally, add the new social network to `schema.json` to finish the integration of the new social network. |
| 1. Go to `tests/test_data.py` and update `test_social_network_url` accordingly, i.e., add a new `(network, username, expected_url)` tuple to the `pytest.mark.parametrize` decorator. | ||
| 2. Go to `tests/conftest.py` and add the new social network to `rendercv_filled_curriculum_vitae_data_model`. | ||
| 3. Set `update_testdata` to `True` in `conftest.py` and run the tests to update the `testdata` folder. | ||
| 3. Set `update_testdata` to `True` in `conftest.py` and [run the tests](./testing.md) to update the `testdata` folder. |
There was a problem hiding this comment.
If you could send this line as a different PR, I would like to merge it.
I do not understand this response. The Twitter icon still exists in fontawesome5 and will exist forever. As it stands there is no way to link an X account, so in my view it is better to use the old icon? |
|
Hi, I'm sorry, I didn't see this response. What I meant was: Twitter as a platform doesn't exist, right? I don't think supporting something that doesn't exist is good. We plan to switch to Typst soon. We can add X support after we switch to Typst. |
|
Yeah I also agree that Twitter no longer exists, but now you are essentially removing a feature (displaying your Twitter/X on your CV) until switching to a new backend. Isn't is better to show the Twitter icon and link people to |
|
I honestly believe it's better to not have X social network support than to mislead users to use the wrong icon in their CVs. Using the wrong icon is just as problematic as having a spelling mistake in a CV, in my opinion. One of the goals of RenderCV is to help people not make mistakes with their CVs and content. Also, the |
2 participants
I see it was removed after #109, but there is currently no replacement. I'd rather see an 'outdated' Twitter icon than not being able to link my X account at all.