fix(cli): place extension-less package documents under documents/#439
Merged
Conversation
Previously, attachments downloaded without an extension were written to the zip root rather than under documents/, breaking the layout expected by consumers of the package. Move them under documents/ with no extension suffix, and keep a backwards-compat read path so older packages still upload correctly. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
documents/. This change places them underdocuments/with no extension suffix, matching the layout for documents that do have an extension.read_documentandget_document_count) so packages produced before this fix still upload correctly.document_basenamehelper so the basename is constructed in one place.Test plan
cargo fmt --check -p reinfer-clicargo clippy -p reinfer-cli -- -D warningscargo test -p reinfer-cli --bin re(25/25 pass)documents/🤖 Generated with Claude Code