Conversation
| observe( | ||
| [ | ||
| 'span[class*="PullRequestHeaderSummary"]', | ||
| '[class*="PullRequestHeaderSummary"]', |
There was a problem hiding this comment.
This is gonna select old PR branch links:
There was a problem hiding this comment.
We're supporting 4 (!) versions of the header element at this point: 3 React-based and a legacy one
There was a problem hiding this comment.
Do remove anything that you can no longer see. GHE support is just a plus, as always.
|
|
|
We shouldn't have removed the input event dispatching: #9337 (comment) |
Trying to decrypt your messages, I suppose that the message is removed from the DOM, but it's not what's being submitted to the servers? |
|
You decrypted it right |
SunsetTechuila
changed the title
|
|
||
| [class^='PullRequestBranchName'], | ||
| /* TODO: Remove after July 2026 */ | ||
| /* Old views */ /* TODO: Drop after legacy PR files view is removed */ |
There was a problem hiding this comment.
Why does Malva format:
[class^='PullRequestBranchName'],
/* Old views */
/* TODO: Drop after legacy PR files view is removed */
.commit-ref,
/* TODO: Drop after July 2026 */
[class^='BranchName'] {
font-size: 12px !important;
}as
[class^='PullRequestBranchName'],
/* Old views */ /* TODO: Drop after legacy PR files view is removed */
.commit-ref,
/* TODO: Drop after July 2026 */
[class^='BranchName'] {
font-size: 12px !important;
}I don't think this is right
There was a problem hiding this comment.
@g-plane can you take a look please? thank you in advance
There was a problem hiding this comment.
A bit redundant given the following comment
| /* Old views */ /* TODO: Drop after legacy PR files view is removed */ | |
| /* TODO: Drop after legacy PR files view is removed */ |
|
What happened here? Did they just change the selectors? I used |
They changed the DOM a bit today |
|
By the way I'll release a new version this week because of this. Maybe in a day or two. Do you reckon they changed the DOM for good? |
| '[class*="PullRequestHeaderSummary"] a[class^="PullRequestBranchName"]', | ||
| '[class*="PullRequestHeaderSummary"] > [class*="PullRequestHeaderSummary"]', // TODO: Remove after July 2026 | ||
| '.base-ref', // TODO: Remove in June 2026 | ||
| '.base-ref', // TODO: Drop after legacy PR files view is removed |
What do you mean? |
|
Basically I'm worried that they will revert these DOM changes after we publish this PR 😂 |
|
The changes I made are backwards compatible |
|
Ready to merge? |
|
Ready or not, here I come. With I'll release a new version within the hour unless something comes up |
|
Ready |
2 participants
Fixes:
actionable-pr-view-fileclean-conversation-headersclear-pr-merge-commit-messagerestore-fileupdate-pr-from-base-branchpr-branch-auto-deletepr-base-commitconversation-activity-filter(on PRs)Fixes this too:
#9443 (comment)
Test URLs
this PR
Screenshot