Skip to content

table-input collapsible-content-button - Disable on mobile#9379

Merged
fregante merged 4 commits into
refined-github:mainfrom
dutchaiagency:codex/disable-table-input-mobile-9358
May 8, 2026
Merged

table-input collapsible-content-button - Disable on mobile#9379
fregante merged 4 commits into
refined-github:mainfrom
dutchaiagency:codex/disable-table-input-mobile-9358

Conversation

@dutchaiagency
Copy link
Copy Markdown
Contributor

@dutchaiagency dutchaiagency commented May 7, 2026

part of #9358

Test URLs

https://github.com/refined-github/refined-github/issues/new?template=1_bug_report.yml&title=%60table-input%60%3A+&labels=bug%2C+help+wanted

Screenshot

Not captured; local verification was static because this change disables table-input and collapsible-content-button on small screens through the existing isSmallDevice feature gate.

Verification

  • npm run build:typescript
  • npx eslint source/features/table-input.tsx source/features/collapsible-content-button.tsx --quiet
  • git diff --check

@github-actions github-actions Bot added the bug label May 7, 2026
@fregante fregante changed the title Disable table input on small screens table-input - Disable on small screens May 7, 2026
@fregante fregante changed the title table-input - Disable on small screens table-input - Disable on small screens due to bug May 7, 2026
@fregante fregante marked this pull request as ready for review May 7, 2026 19:32
@fregante
Copy link
Copy Markdown
Member

fregante commented May 7, 2026

Please do the same for collapsible-content-button in this PR

@fregante fregante changed the title table-input - Disable on small screens due to bug table-input collapsible-content-button - Disable on mobile May 7, 2026
@dutchaiagency
Copy link
Copy Markdown
Contributor Author

dutchaiagency commented May 7, 2026

Done in 7e8af40. I added the same small-screen feature gate to collapsible-content-button and reran TypeScript, scoped ESLint for both files, and git diff --check.

Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me. Technically the same issue applies to small viewports on large screens, but they do have the option to make the viewport bigger and fix the issue.

It's not clear if the responsiveness of the component is restored if we drop the elements under a certain viewport width.

@SunsetTechuila
Copy link
Copy Markdown
Member

I suggest marking this as a workaround and adding a TODO to remove it once the issue is properly fixed

@fregante
Copy link
Copy Markdown
Member

fregante commented May 8, 2026

Unfortunately not enough, the issue still appears on large windows.

Screenshot 12

@fregante fregante closed this May 8, 2026
@fregante fregante reopened this May 8, 2026
Copy link
Copy Markdown
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this workaround anyway, without closing the parent issue

@fregante fregante enabled auto-merge (squash) May 8, 2026 15:59
@fregante fregante merged commit e64b5c2 into refined-github:main May 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants