update-pr-from-base-branch - Replace native button#9366
Merged
Conversation
SunsetTechuila
commented
May 7, 2026
| pageDetect.isPRConversation, | ||
| ], | ||
| exclude: [ | ||
| pageDetect.isClosedConversation, |
Member
Author
There was a problem hiding this comment.
Closed PR can be reopened
fregante
reviewed
May 7, 2026
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
I like the change even though I'm hesitant to replace native buttons with API-based ones where a lot more can go wrong
fregante
reviewed
May 7, 2026
| } | ||
|
|
||
| if (elementExists('.octicon-alert-fill', stateIcon)) { | ||
| // Button group won't exist if it wasn't previously added |
fregante
approved these changes
May 7, 2026
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Let's merge a few approved PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9365
Fixes #9229
Test URLs
Screenshot